-
-
Notifications
You must be signed in to change notification settings - Fork 90
Linting setup updates #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,12 @@ | |
| /coverage/ | ||
| !.* | ||
| .*/ | ||
| /pnpm-lock.yaml | ||
| ember-cli-update.json | ||
| *.html | ||
| *.hbs | ||
| *.md | ||
|
|
||
|
|
||
| # ember-try | ||
| /.node_modules.ember-try/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,16 @@ | ||
| /* eslint-disable prettier/prettier */ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'], | ||
| plugins: [ | ||
| 'stylelint-declaration-strict-value', | ||
| 'stylelint-order' | ||
| ], | ||
| extends: ['stylelint-config-standard'], | ||
| plugins: ['stylelint-declaration-strict-value', 'stylelint-order'], | ||
| rules: { | ||
| // Disables this rule to allow case agnostic color hex values | ||
| 'color-hex-case': null, | ||
| // Require the long version of hex colors | ||
| 'color-hex-length': 'long', | ||
| // Disallow ids | ||
| 'selector-max-id': 0, | ||
| // Require that color, background-color, etc use variables for colors, instead of direct values | ||
| 'scale-unlimited/declaration-strict-value': [ | ||
| ['/color/'] // We can enforce variables for font-size, margin, etc as well by adding here | ||
| ['/color/'], // We can enforce variables for font-size, margin, etc as well by adding here | ||
| ], | ||
| } | ||
| }, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes, prettier/prettier */ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes */ | ||
| import Component from '@glimmer/component'; | ||
|
|
||
| export default class EsCardContentComponent extends Component { | ||
| } | ||
| export default class EsCardContentComponent extends Component {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes, prettier/prettier */ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes */ | ||
| import Component from '@glimmer/component'; | ||
|
|
||
| export default class EsCardComponent extends Component { | ||
| } | ||
| export default class EsCardComponent extends Component {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes, prettier/prettier */ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes */ | ||
| import Component from '@glimmer/component'; | ||
|
|
||
| export default class EsFooterContributionsComponent extends Component { | ||
| } | ||
| export default class EsFooterContributionsComponent extends Component {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| /* eslint-disable prettier/prettier */ | ||
| import Component from '@glimmer/component'; | ||
|
|
||
| export default class EsFooterHelpComponent extends Component { | ||
|
|
||
| get linkUrl() { | ||
| return this.args.contributeLink || 'https://github.com/ember-learn/ember-website'; | ||
| } | ||
| get linkUrl() { | ||
| return ( | ||
| this.args.contributeLink || 'https://github.com/ember-learn/ember-website' | ||
| ); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes, prettier/prettier */ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes */ | ||
| import Component from '@glimmer/component'; | ||
|
|
||
| export default class EsFooterInfoComponent extends Component { | ||
| } | ||
| export default class EsFooterInfoComponent extends Component {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes, prettier/prettier */ | ||
| /* eslint-disable ember/no-empty-glimmer-component-classes */ | ||
| import Component from '@glimmer/component'; | ||
|
|
||
| export default class EsLinkCardComponent extends Component { | ||
| } | ||
| export default class EsLinkCardComponent extends Component {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.