Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Merged
|
2/16 Files got Smaller 🎉: Details
14/16 Files stayed the same size 🤷: Details
Created by ember-asset-size-action |
The updated packages changed some of the rules which means our existing code needs changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR extracted from #1193 for all the lint errors that needed to be fixed to get it landed.
For anyone following along, I'm doing this because my philosophy is to have a single PR that has one logical change. If you do an upgrade PR all it should be doing is upgrading, not fixing any lints.
If you want to read more on my philosophy you can check out this blog post ;) https://mainmatter.com/blog/2021/05/26/keeping-a-clean-git-history/