Skip to content

Bugfix - If a header precedes a section, move it inside the secton#36

Closed
jenweber wants to merge 3 commits intomainfrom
bugfix-a11y-header
Closed

Bugfix - If a header precedes a section, move it inside the secton#36
jenweber wants to merge 3 commits intomainfrom
bugfix-a11y-header

Conversation

@jenweber
Copy link
Contributor

@jenweber jenweber commented Feb 6, 2020

I came across this while working on the website redesign.

Before

<h2 id="some-title">Some title</h2>
<section aria-labelledby="some-title">
  <p>Ember is doing better at accessibility</p>
<section>

After

<section aria-labelledby="some-title">
  <h2 id="some-title">Some title</h2>
  <p>Ember is doing better at accessibility</p>
<section>

@jenweber jenweber requested review from MelSumner and mansona February 6, 2020 04:04
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

@jenweber jenweber force-pushed the bugfix-a11y-header branch from aea21cb to 75c0f30 Compare June 3, 2022 12:37
@MelSumner
Copy link
Member

@jenweber how do we re-run these tests?

@jenweber
Copy link
Contributor Author

jenweber commented Mar 2, 2023

I think the easiest thing to do is to rebase the branch. I can do that!

@MinThaMie
Copy link
Contributor

Closed in favour of #159

@MinThaMie MinThaMie closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants