Skip to content
This repository was archived by the owner on Aug 1, 2022. It is now read-only.

Allow React 17 as peer dependency#123

Merged
embiem merged 1 commit intoembiem:developfrom
daiyi:patch-1
Nov 7, 2021
Merged

Allow React 17 as peer dependency#123
embiem merged 1 commit intoembiem:developfrom
daiyi:patch-1

Conversation

@daiyi
Copy link
Contributor

@daiyi daiyi commented Jun 4, 2021

React 17 has been around for a little bit. I'm using it in a new project and would like to use this library, but the peerDependencies are too restrictive and I get this error:

% npm install react-canvas-draw --save
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: project@1.0.0
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"16.x" from react-canvas-draw@1.1.1
npm ERR! node_modules/react-canvas-draw
npm ERR!   react-canvas-draw@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

The release notes suggest that there should be exceeding few breaking changes between React 16 and 17, so I believe this is a safe change: https://reactjs.org/blog/2020/10/20/react-v17.html

React 17 has been around for a little bit. I'm using it in a new project and would like to use this library, but the `peerDependencies` are too restrictive. The release notes suggest that there should be exceeding few breaking changes between React 16 and 17, so I believe this is a safe change: https://reactjs.org/blog/2020/10/20/react-v17.html
@embiem
Copy link
Owner

embiem commented Nov 7, 2021

Thanks! I couldn't find any issues when used with React 17, so I'll merge this.

@embiem embiem merged commit 6d14f27 into embiem:develop Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants