bug: LdModal calls ldmodalclosed event 2 times on single modal close

[ssuchkov]

Prerequisites

• I know how to contribute a proper bug report.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Liquid version

5.14.0

Framework bindings

React

Current behavior

LdModal calls ldmodalclosed 2 times on modal close.

Expected behavior

LdModal calls ldmodalclosed 1 time on modal close.

Steps to reproduce

code like this reveals is

const modalRef = useRef(null)

return (
  <>
    <LdModal blurryBackdrop ref={modalRef} onLdmodalclosed={() => alert('Modal closed')}>
      <LdTypo style={{ textAlign: 'center' }}>I'm a modal dialog.</LdTypo>
    </LdModal>

    <LdButton onClick={() => modalRef.current.showModal()}>
      Open Modal
    </LdButton>
  </>
)

Code reproduction URL

https://stackblitz.com/edit/github-lmnmdfxu?file=src%2FApp.tsx

Additional information

No response

[renet]

Thanks for reaching out. For now, a possible workaround would be to use onLdmodalclosing={...}, as this seems to be triggered only once. Can you confirm that this is a valid workaround for you?

[ssuchkov]

Can you confirm that this is a valid workaround for you?

This is exactly what we used instead of onLdmodalclosed. Thank you.