Skip to content

feat(ld-select): render option html content in trigger button#638

Merged
borisdiakur merged 1 commit intomainfrom
feat/ld-select
Apr 13, 2023
Merged

feat(ld-select): render option html content in trigger button#638
borisdiakur merged 1 commit intomainfrom
feat/ld-select

Conversation

@borisdiakur
Copy link
Copy Markdown
Contributor

@borisdiakur borisdiakur commented Apr 13, 2023

Description

This PR adds a feature to the ld-select component, enabling it to render HTML content from selected options in the select trigger button. Previously the component only rendered the text content of the options. This feature allows for more customization of the select component.

Resolves #637

Type of change

  • Feature

Is it a breaking change?

  • No

How Has This Been Tested?

Please describe the tests that you've added and run to verify your changes.
Provide instructions, so we can reproduce.

  • unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
liquid ✅ Ready (Inspect) Visit Preview Apr 13, 2023 10:16am

@borisdiakur borisdiakur merged commit c3c3058 into main Apr 13, 2023
@borisdiakur borisdiakur deleted the feat/ld-select branch April 13, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customize ld-select selected options rendering

1 participant