Fix : Submenus are inaccessible via keyboard Enter/Space (Response::fake_primary_click)#5230
Closed
abdul2801 wants to merge 8 commits intoemilk:masterfrom
Closed
Fix : Submenus are inaccessible via keyboard Enter/Space (Response::fake_primary_click)#5230abdul2801 wants to merge 8 commits intoemilk:masterfrom
abdul2801 wants to merge 8 commits intoemilk:masterfrom
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/5230-patches |
emilk
approved these changes
Dec 12, 2024
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Author
|
looks like the hovering_current_submenu() check was causing the issue.Just checking for clicked() works fine |
Owner
|
still broken, but in a new way |
Author
Hmm , Is it the fact that the other menu(nested 1) wont open while nested is being hover with Enter Key
|
Collaborator
|
I'll close this since we now have a new menu implementation (See #5716) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Submenus are inaccessible via keyboard Enter/Space
crates/egui/src/menu.rs: Enhanced the submenu opening condition to include pointer hovering over the current submenu and button clicks.Closes Submenus are inaccessible via keyboard Enter/Space (
Response::fake_primary_click) #5221