Add UiBuilder::global_scope and UiBuilder::id
#7372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmerlin
reviewed
Jul 22, 2025
|
Preview available at https://egui-pr-preview.github.io/pr/7372-fixid |
lucasmerlin
reviewed
Jul 23, 2025
Contributor
Author
|
How does merging work? |
Collaborator
|
I usually go through all approved PRs with @emilk every tuesday, but hes on holiday right now so it'll have to wait until next tuesday. |
emilk
changed the title
UiBuilder::global_scope and UiBuilder::id
emilk
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new flag to the UiBuilder so that it is possible to move child widgets around the ui tree without losing state information.
Currently there is no way to create child widgets with the same id at different locations in the ui tree since ids change in relation the the parent id. With the new flag a unique global scope can be created which always results in the same ids even at different locations.
You still need to ensure that the widgets only get rendered once in frame.
This feature can be used to fix a issue i am having with the https://github.com/lucasmerlin/hello_egui crate.