-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add rotation gesture support for trackpad sources #7453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
I implemented GestureEvent support utilizing |
emilk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Code LGTM, but we should have some way of testing this in egui_demo_app. We have the Multi Touch demo, but that doesn't work with this PR.
|
Preview available at https://egui-pr-preview.github.io/pr/7453-rotationgesture |
|
The |
|
We could rename |
|
Keeping it called I have also been working on some changes in |
c0d186a to
711ce9f
Compare
emilk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice - works great with my trackpad!
This adds support to receive rotation gesture information from sources that don't provide touch events, such as trackpads on MacOS. Currently, only the
winitbackend passes through the necessary information. I would also like to add support for the web backend on Safari, as that generates aGestureEvent(MDN, WebKit JS) with rotation information. However, since that is a non-standard API, it is not yet exposed inweb-sys.