fix: Prevent duplicate toasts with same text#686
Open
pimmee wants to merge 2 commits intoemilkowalski:mainfrom
Open
fix: Prevent duplicate toasts with same text#686pimmee wants to merge 2 commits intoemilkowalski:mainfrom
pimmee wants to merge 2 commits intoemilkowalski:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes so that duplicate toasts with the exact same (string) text are not shown.
While it could be opt in via a
preventDuplicateoption or similar, I can't think of any use case where you would want to display multiple toasts with exact same message, so making this default like other libraries such as notistack makes sense IMO.Note: A more advanced solution could be implemented to also compare non-strings, but most toasts are string messages anyway so this is good enough IMO.