Fix Undefined Symbols while building llvm#1384
Fix Undefined Symbols while building llvm#1384IsabelParedes merged 4 commits intoemscripten-forge:mainfrom
Conversation
|
Hmm, I thought the uploads failed but I see 19.1.2 here Am I missing something ? |
|
@anutosh491 the upload only fails client sided, but not on the server side! |
|
Ahh cool. Needed llvm19 for CppInterOp which you already merged. Thanks for the clarification :) |
|
Might just work out without the |
|
I realized the way i was passing the flags was hampering the symbols. The minor change in the last commit fixes most of it. It's only this one symbol that is undefined Need to figure out how to fix this. If anyone has ideas, they are welcome ! |
|
Hey @DerThorsten I see you had added this through ec21b92 recipes/recipes/recipes_emscripten/llvm/build.sh Lines 7 to 8 in a4c4a03 Maybe we won't like to have Just curious if we need to have no |
|
This is now ready. The above |
| -DCMAKE_CXX_FLAGS="-Dwait4=__syscall_wait4 -isystem $EMSCRIPTEN_FORGE_EMSDK_DIR/upstream/emscripten/cache/sysroot/include/c++/v1" | ||
|
|
||
| # Build step | ||
| EMCC_CFLAGS='-sERROR_ON_UNDEFINED_SYMBOLS=0' emmake make -j1 |
There was a problem hiding this comment.
thanks for the review :)
Not sure why the upload to Quetz failed on all 3 previous updates on llvm
Need this for CppInterOp