Fix exception suppression in asgi transport#2669
Merged
lovelydinosaur merged 11 commits intoencode:masterfrom May 21, 2023
Merged
Fix exception suppression in asgi transport#2669lovelydinosaur merged 11 commits intoencode:masterfrom
lovelydinosaur merged 11 commits intoencode:masterfrom
Conversation
| async with httpx.AsyncClient(app=raise_exc, transport=transport) as client: | ||
| response = await client.get("http://www.example.org/") | ||
|
|
||
| assert response.status_code == 500 |
Contributor
There was a problem hiding this comment.
What's the behaviour of this test before the code change?
Contributor
Author
There was a problem hiding this comment.
Test failed with RuntimeError being raised from raise_exc
Co-authored-by: Tom Christie <tom@tomchristie.com>
lovelydinosaur
approved these changes
Apr 21, 2023
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Seems reasonable, yup.
zanieb
approved these changes
Apr 21, 2023
Contributor
|
Okay, let's also add this to the
Perhaps? |
lovelydinosaur
previously requested changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description:
If httpx client uses asgi transport with
raise_app_exceptions=Falseand response is not complete, exception is still raised.This is mostly come up in tests where you want to check how your application behave in error states. But currently it works only with non-streaming responses, which is quite limiting.
I propose simple fix for such non-complete responses to be able to comply with the
raise_app_exceptions=False.Test case included.