Skip to content

Move code from the shell extension to the core  #111

@end2endzone

Description

@end2endzone

Is your feature request related to a problem? Please describe.
There is a lot of code in the Shell Extension that could be moved to the core in order to be reusable or tested.

Describe the solution you'd like
What ever code that can be moved to the core is good.

  • Setting global properties:
    • log.directory
  • Create ShellAnythingApp, App or Settings class to store global settings. This class shall be a good candidate for moving code from DLL to the core.
    • Move function InitConfigManager().
    • Move function LogEnvironment(). Won't do. Function is already too much win32/Windows specific. Not appropriate for the core.
    • Move function PropertyManager::SetApplicationPath().
    • Move function InstallDefaultConfigurations().
  • Move code that "execute all actions of a menu" from CContextMenu.cpp to Menu.cpp.
  • Move "menu finding code" from unit test TestConfigManager.cpp#L76:L128 to ConfigManager,Configuration and Menu classes (close to function FindMenuByCommandId()).

Describe alternatives you've considered
Duplicated code ?!?!?

Additional context
N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    code cleanupThe code needs optimizationenhancementNew feature or request

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions