-
Notifications
You must be signed in to change notification settings - Fork 31
Closed
Labels
code cleanupThe code needs optimizationThe code needs optimization
Milestone
Description
Describe the bug
During configuration time, CMake is trying to detect if NSIS is installed. If NSIS is not installed on the system, the following is output on the console:
-- Could NOT find NSIS (missing: NSIS_MAKE)
This message is confusing to users because is looks like a warnings message when NSIS is never used by ShellAnything.
To Reproduce
Steps to reproduce the behavior:
- Configure the project.
- CMake will try to detect if NSIS is installed.
- The message
Could NOT find NSIS (missing: NSIS_MAKE)is displayed on the console.
Expected behavior
NSIS is not required anymore for the project. The custom detection script FindNSIS.cmake is not required anymore. It should have been deleted when #101 was implemented. The find_package(NSIS) from CMakeLists.txt line 8 shall also be removed.
Screenshots
N/A
Environment
N/A
Additional context
N/A
Metadata
Metadata
Assignees
Labels
code cleanupThe code needs optimizationThe code needs optimization