fix(compartment-mapper): moduleSourceHook uses specifier for exit module's canonicalName#3115
Open
fix(compartment-mapper): moduleSourceHook uses specifier for exit module's canonicalName#3115
Conversation
…ule's canonicalName Fixes issue where `canonicalName` reported as the _requesting_ (parent) compartment's `canonicalName`. Builtins are not necessarily canonical names, however. Removes unused `ModuleSourceHook`'s "error" module source type.
Member
Author
📚 Pull Request Stack
Managed by gh-stack |
🦋 Changeset detectedLatest commit: abe2c9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kriskowal
approved these changes
Mar 5, 2026
| reexports?: string[] | undefined; | ||
| sha512?: string | undefined; | ||
| } | ||
| | { error: string } |
Member
There was a problem hiding this comment.
Error seems to be missing. Is that deliberate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where
canonicalNamereported as the requesting (parent) compartment'scanonicalName. Builtins are not necessarily canonical names, however.Removes unused
ModuleSourceHook's "error" module source type.