feat: add custom AdEventListener to Manilo#133
feat: add custom AdEventListener to Manilo#133loicsiret wants to merge 3 commits intoeneim:dev-v1from
Conversation
|
Thanks for the PR, will review this soon this weekend. |
|
[Q] @loicsiret My current concern is the client implementing the AdEventListener to the Activity/Fragment or something that has a lifecycle, and register it as an AdEventListener to the Manilo instance (whose lifecycle is equal to the Application). An easy way to address this is to put a comment to (Ask this because, from the library's point of view, one of the responsibility is to make people's lives easier by automating things :D, but on the other hand I don't want to put any tech debt on the maintainer's shoulder if it can be solved by well-communication.) |
|
I totally understand and I agree with it. If you add a listener as an user of the Lib it is your responsibility to remove it properly. |
|
@loicsiret Sorry for being late. My current thinking progress:
|
This PR will allow user to register/unregister AdEventListener on a Manilo instance.