Skip to content
This repository was archived by the owner on Dec 24, 2024. It is now read-only.
This repository was archived by the owner on Dec 24, 2024. It is now read-only.

Promote self._actual_graph to a property #306

@eunjongkim

Description

@eunjongkim

Is your feature request related to a problem? Please describe.
I found that the Graph object used to generate graph outputs (currently self._actual_graph: ones we get from e.g., .dot_graph() method) is created upon initialization but stays unchanged after, for example, updating a node of the graph already initialized. This can be useful when we want to put an attribute to each calibration node to represent calibration status and color the nodes according to their calibration status in graph outputs. This means once the graph is run, the calibration status of constituent nodes (currently self._original_nodes) should have updated, so we want the graph output should be regenerated once they are called.

Describe the solution you'd like
Promoting the attribute self._actual_graph in the file /pipeline/graph_experiment.py to a property with @property decorator, such that it calls a function of self._original_nodes, easily makes it possible to achieve what I want. I can create a pull request if this sounds like a good change.

Additional context
I was able to do something like this with my custom script:
image

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions