config: plumb v2 bootstrap file to cluster manager instantiation.#1369
config: plumb v2 bootstrap file to cluster manager instantiation.#1369htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
Not used yet, but the plan is in a followup PR to allow the bootstrap to override the CDS config and allow experimental use of the v2 APIs for CDS/EDS (sans constraint checks).
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
A couple of questions to get started.
|
|
||
| /** | ||
| * @return const std::string& the path to the v2 bootstrap file. | ||
| */ |
There was a problem hiding this comment.
Q: Is it worth having a different option for this? I feel like -c could just detect whether it's JSON or proto (or v2 JSON) via attempting parsing?
There was a problem hiding this comment.
At least during the transition, we will be consuming both v1 JSON and v2 proto (in JSON format), and overlaying them, since the v2 proto handling isn't complete. So, I think for now this is probably the way to go.
There was a problem hiding this comment.
Sounds good. Can you add TODO here just to let people know? Same below for other comment?
| const LocalInfo::LocalInfo& local_info, | ||
| AccessLog::AccessLogManager& log_manager) PURE; | ||
| virtual ClusterManagerPtr | ||
| clusterManagerFromJson(const Json::Object& config, const envoy::api::v2::Bootstrap& bootstrap, |
There was a problem hiding this comment.
Any reason we are not just converting JSON to bootstrap like we are doing in other PRs? That seems like right long term approach?
There was a problem hiding this comment.
Will add this in a later PR, once we grow the bootstrap proto to encompass the full cluster manager, so yeah, this is the plan, but for a minimal CDS/EDS end-to-end capability this isn't needed yet.
…event. (envoyproxy#1371) Automatic merge from submit-queue. Support Mixer TCP filter to send string type of attribute "connection.event" **What this PR does / why we need it**: Mixer need to keep tracking of TCP connection creation rate. Support Mixer TCP filter to send attribute "connection.event". In Check() call, "connection.event" is set to "open" In periodical Report() call, "connection.event" is set to "continue" In final Report() call, "connection.event" is set to "close" **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes envoyproxy#1369 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
**Description** This commit adds support for the first party Anthropic API api.anthropic.com in the project. Notably, this adds the passthrough "translator" that captures the token usage as well as the API for the Anthropic API key configuration which is slightly different from both the existing APIKey security policy (authorization header) as well as Azure API key (api-key header) in the sense that it requires the key passed as "x-api-key" header. **Related Issues/PRs (if applicable)** #847 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
**Description** This PR adds the Anthropic logo to the LLM providers section and sorts all providers alphabetically for better organization. **Changes:** - Added Anthropic SVG logo to static assets - Updated provider list in both README.md and website component - Implemented alphabetical sorting for the provider list on homepage - Updated website description to clarify that providers are displayed alphabetically **Related Issues/PRs:** Related PR: #1369 --------- Signed-off-by: Erica Hughberg <erica.sundberg.90@gmail.com>
2 participants
Not used yet, but the plan is in a followup PR to allow the bootstrap to override the CDS config and
allow experimental use of the v2 APIs for CDS/EDS (sans constraint checks).