Add failing test for isMemo bug (#2390)#2408
Open
bdwain wants to merge 1 commit intoenzymejs:masterfrom
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2408 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 49 49
Lines 4204 4207 +3
Branches 1130 1130
=======================================
+ Hits 4049 4052 +3
Misses 155 155
Continue to review full report at Codecov.
|
13 tasks
ljharb
force-pushed
the
master
branch
4 times, most recently
from
2227326 to
0d5ead7
Compare
ljharb
force-pushed
the
master
branch
3 times, most recently
from
43eb75e to
39e6b1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to #2390 . By throwing away the type information of the render result, we cause isMemo checks to fail on elements that have gone through the wrapper. Ideally they would pass the isMemo check