Skip to content

SeerMainWindow: Change action buttons when status changed#423

Merged
epasveer merged 1 commit intoepasveer:mainfrom
QuangNguyenMinh123:feature/adjust_action_buttons_when_status_changed
Feb 18, 2026
Merged

SeerMainWindow: Change action buttons when status changed#423
epasveer merged 1 commit intoepasveer:mainfrom
QuangNguyenMinh123:feature/adjust_action_buttons_when_status_changed

Conversation

@QuangNguyenMinh123
Copy link
Contributor

I see that many other IDEs disable action buttons when a program is running or halted.
I believe Seer should do the same. This could also prevent potential bugs.
Screencast from 01-25-2026 11:13:33 PM.webm

@epasveer
Copy link
Owner

You're probably right. But there's more menu bar items to disable, including some from the Control menu and others....

image

@epasveer
Copy link
Owner

I'm going to hold off on this one for a while. I'm making changes to the menus. So doing this, on a bigger scale, can be done later.

@QuangNguyenMinh123
Copy link
Contributor Author

Can this MR be merged soon?

@epasveer
Copy link
Owner

Let me review it again.

@epasveer
Copy link
Owner

These buttons/menus need disabling when the program is running.

image image

@QuangNguyenMinh123 QuangNguyenMinh123 force-pushed the feature/adjust_action_buttons_when_status_changed branch 4 times, most recently from 46a3ac7 to 8518548 Compare February 15, 2026 16:55
@QuangNguyenMinh123
Copy link
Contributor Author

Currently, I face a problem:
Some action buttons won't return to default state (enable) when a gdb process is terminated during debug. Please see bellow image
image
Though these button state will be normal when a new gdb session is started, so this isn't a big issue

@QuangNguyenMinh123
Copy link
Contributor Author

Another problem is dealing with action Record and Record Direction
I have never used these buttons
When I enable Record and set Direction and run (Continue F8) the program, at some points, I will no longer to stop the program (interrupt)
To reproduce:

  1. start a new debug session
  2. continue f8
  3. interrupt
  4. enable record (click on Record button)
  5. continue f8, press until program run (in my PC, I need 2 clicks). Check status bar on lower right of Seer
  6. now, try to stop program by interrupt it, but interrupt won't change program from running to stopped -> issue is reproduced

@QuangNguyenMinh123
Copy link
Contributor Author

Another problem is dealing with action Record and Record Direction I have never used these buttons When I enable Record and set Direction and run (Continue F8) the program, at some points, I will no longer to stop the program (interrupt) To reproduce:

  1. start a new debug session
  2. continue f8
  3. interrupt
  4. enable record (click on Record button)
  5. continue f8, press until program run (in my PC, I need 2 clicks). Check status bar on lower right of Seer
  6. now, try to stop program by interrupt it, but interrupt won't change program from running to stopped -> issue is reproduced

Regarding this issue, I checked out the main branch of Seer to try to reproduce it. It turns out the issue still exists even on the main branch

@epasveer
Copy link
Owner

Hi @QuangNguyenMinh123

I've thought about this some more. Lets go back to your original way.

When the program is running, disable the continue/step/next/stepi/nexti/finish buttons on the Control Menu and the Tool Bar. Then re-enable them when a break point is reached.

For the Record/Visualizer buttons, just leave them as they were. If users want these, we can pursue this later.

@epasveer
Copy link
Owner

epasveer commented Feb 17, 2026

Regarding this issue, I checked out the main branch of Seer to try to reproduce it. It turns out the issue still exists even on the main branch

Okay, cool. I'll create a separate issue and will on this myself.

Oh, and thanks for the steps to reproduce the problem.

@QuangNguyenMinh123 QuangNguyenMinh123 force-pushed the feature/adjust_action_buttons_when_status_changed branch from 521f8ce to 8518548 Compare February 18, 2026 15:21
@QuangNguyenMinh123
Copy link
Contributor Author

@epasveer done, please help me review

@QuangNguyenMinh123 QuangNguyenMinh123 force-pushed the feature/adjust_action_buttons_when_status_changed branch from 8518548 to 4257f16 Compare February 18, 2026 15:24
@epasveer
Copy link
Owner

Looks good, @QuangNguyenMinh123.

I'll pull the MR.

@epasveer epasveer merged commit 5125a94 into epasveer:main Feb 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants