Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebar3 currently doesn't build with OTP-29.0-rc1 due to new warnings about deprecated language features. This fixes them. Some notes:
rebar_usermodule uses "interesting" control flow that depends on old-stylecatchsemantics in at least one place, possibly more. Where I wasn't absolutely sure no such dependency existed, I used a helper function to emulate old-style catches. This can hopefully be cleaned up in the future.rebar_prv_cover:cover_compile_file/1function usescatchto turn anyexitorerrorin the call into acase_clauseerror. The rewrite preserves that.ec_talk:get_integer/1had an error (it spelled'EXIT'wrong) which has been corrected as part of eliminating the old-style catch.