Record InvalidFieldError when updating a non-existence slot#308
Merged
Conversation
jhnaldo
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Section 6.1.7.2 of the ECMAScript specification, internal slots cannot be dynamically added to an object. However, issue #3204 in ecma262 describes a case where the ClassDefinitionEvaluation algorithm attempted to access the [[PrivateMethods]] and [[Fields]] slots, which may or may not be defined depending on the situation.
This issue was not detected in esmeta, so this PR modifies the behavior to record an
InvalidFieldErrorwhen updating an internal slot if it does not exist in the record and is not manually defined inmanuals/types.