Skip to content

change to facet limits#147

Open
nocollier wants to merge 2 commits intomainfrom
facet-limit-change
Open

change to facet limits#147
nocollier wants to merge 2 commits intomainfrom
facet-limit-change

Conversation

@nocollier
Copy link
Member

Proposed change to address #146

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/esg_fastapi
   __init__.py20100% 
   utils.py310100% 
src/esg_fastapi/api
   __init__.py00100% 
   globus.py770100% 
   main.py150100% 
   models.py4480100% 
   routes.py520100% 
   types.py370100% 
src/esg_fastapi/configuration
   __init__.py130100% 
   globus.py80100% 
   logging.py290100% 
   opentelemetry.py200100% 
   profiling.py150100% 
src/esg_fastapi/observability
   __init__.py30100% 
   main.py200100% 
   metrics.py350100% 
   models.py40100% 
   routes.py100100% 
tests
   __init__.py00100% 
   conftest.py150100% 
   test_app.py430100% 
   test_caching.py450100% 
   test_esgsearch_parity.py370100% 
   test_globus_client.py900100% 
   test_metrics.py350100% 
   test_models.py460100% 
   test_observability.py470100% 
   test_settings.py500100% 
   test_utils.py360100% 
TOTAL12630100% 

Tests Skipped Failures Errors Time
84 0 💤 0 ❌ 0 🔥 2.389s ⏱️

@nocollier
Copy link
Member Author

nocollier commented Nov 21, 2025

Collectively on Slack we decided to pause this merge. From Lee:

All right, I have new information from the Globus Search team.

  1. They are deploying a hotfix to increase the limits to a number high enough that our ESGF queries will no longer fail. This will fix the immediate issue and give us some breathing room. I’ll let you know when it’s been deployed so we can confirm the issue is fixed.
  2. It turns out, they have been “soft limiting” facet sizes to 5000 all along. So even though we were asking for 2 billion, we were never getting more than 5000. The change today was to add a hard limit on how much you ask for.
  3. Globus Search team would like us (ESGF) to change our bridge FastAPI to change the requested facet size from 2 billion to 5000. Because of (2) above, this will not change the behavior we’re seeing in production at all.
  4. Just a reminder, we should never be requesting a facet on the id field. (We don’t think anyone is doing that now. this is just a reminder.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant