Fix WebSocket disconnection and data loss when opening editor#815
Merged
jesserockz merged 1 commit intomainfrom Oct 13, 2025
Merged
Fix WebSocket disconnection and data loss when opening editor#815jesserockz merged 1 commit intomainfrom
jesserockz merged 1 commit intomainfrom
Conversation
jesserockz
approved these changes
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where opening the editor caused the dashboard WebSocket to disconnect and lose all device data, resulting in "Connection lost/restored" messages and empty device cards after closing the editor.
Problem
When opening the file editor:
disconnectedCallback, unsubscribing from WebSocket collectionSolution
The WebSocket collection was too aggressive in trying to clean up resources. It disconnected and cleared data whenever the subscriber count reached zero, even though the dashboard page was still active and would need the connection again immediately. This issue may not have been caught during initial testing due to browser caching or timing variations in component lifecycle events.
Modified
src/util/websocket-collection.tsto keep the WebSocket connection alive and preserve cached data for the lifetime of the dashboard page, regardless of component mount/unmount cycles. This ensures:Changes
Testing