Skip to content

Fix WebSocket leak in streamLogs and logs target dialog removeChild error #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 2 commits into from
Feb 8, 2026
Merged

Fix WebSocket leak in streamLogs and logs target dialog removeChild error #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9b51b8
Fix logs target dialog removeChild error
bdraco Feb 4, 2026
7660542
compileConfigurationMetadata leaks sockets
bdraco Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/api/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ export const streamLogs = (
}

return new Promise((resolve, reject) => {
let done = false;

socket.addEventListener("message", (event) => {
const data = JSON.parse(event.data);
if (data.event === "line") {
Expand All @@ -93,6 +95,8 @@ export const streamLogs = (
return;
}

done = true;
socket.close();
if (data.code === 0) {
resolve(undefined);
} else {
Expand All @@ -114,7 +118,9 @@ export const streamLogs = (
});

socket.addEventListener("close", () => {
reject(new Error("Unexpected socket closure"));
if (!done) {
reject(new Error("Unexpected socket closure"));
}
});
});
};
2 changes: 1 addition & 1 deletion src/logs-target/logs-target-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class ESPHomeLogsTargetDialog extends LitElement {
}

private _handleClose() {
this.parentNode!.removeChild(this);
this.parentNode?.removeChild(this);
}

static styles = [
Expand Down