Ppd42 x by pi4homez · Pull Request #577 · esphome/esphome-core

pi4homez · 2019-03-31T09:29:09Z

Description:

Related issue (if applicable): fixes

Pull request in esphome with python changes (if applicable): esphome/esphome#
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Checklist:

[x ] The code change is tested and works locally.
[x ] The code change follows the standards

If user exposed functionality or configuration variables are added/changed:

[X ] Documentation added/updated in esphome-docs.

OttoWinter · 2019-03-31T13:14:42Z

platformio.ini

    FastLED@3.2.0
    NeoPixelBus@2.4.1
-    ESPAsyncTCP@1.2.0
+    ESPAsyncTCP@1.1.3


Remove this.

OttoWinter · 2019-03-31T13:17:06Z

src/esphome/sensor/ppd42x_sensor.h

+
+namespace sensor {
+
+class Ppd42xSensorComponent : public PollingSensorComponent {


This class shouldn't inherit from PollingSensorComponent but from PollingComponent. In your current design both PM10 and pm2.5 values will be published to the same sensor, which is wrong. Please see PMSx003 example for how to split the two values.

OttoWinter · 2019-03-31T13:17:15Z

src/esphome/sensor/ppd42x_sensor.cpp

+std::string Ppd42xSensorComponent::icon() { return "mdi:arrow-expand-vertical"; }
+
+int8_t Ppd42xSensorComponent::accuracy_decimals() {
+  return 2;  // cm precision


Stale comment

OttoWinter · 2019-03-31T13:17:31Z

src/esphome/sensor/ppd42x_sensor.cpp

+
+float Ppd42xSensorComponent::get_setup_priority() const { return setup_priority::HARDWARE_LATE; }
+std::string Ppd42xSensorComponent::unit_of_measurement() { return "µg/m³"; }
+std::string Ppd42xSensorComponent::icon() { return "mdi:arrow-expand-vertical"; }


wich icon you recommend?

See other particulate matter sensors, for example pmsx003

src/esphome/sensor/ppd42x_sensor.cpp

OttoWinter · 2019-03-31T13:19:53Z

src/esphome/sensor/ppd42x_sensor.cpp

+    float result = Ppd42xSensorComponent::us_to_pm(this->timeout_us_, time_pm_10_0);
+    this->publish_state(result);
+    ESP_LOGD(TAG, "'%s' - Got PM10.0 Concentration: %.1f µg/m³", this->name_.c_str(), result);
+    this->publish_state(result);


Don't double publish

…o PPD42X

OttoWinter · 2019-03-31T16:36:08Z

Your PR contains commits that are not part of this PR (see files tabs, changes are listed there that have nothing to do with this PR). This is due to an incorrect merge. Please see contributing guide for merging dev correctly.

OttoWinter · 2019-04-07T14:01:45Z

src/esphome/sensor/ppd42x.cpp

+              this->timeout_us_);
+  uint32_t duration_pl_10_0 = pulseIn(this->pl_10_0_sensor_->pl_pin_->get_pin(),
+                                      uint8_t(!this->pl_10_0_sensor_->pl_pin_->is_inverted()),
+              this->timeout_us_);


Don't do this inside loop() - Since the timeout is ms this will slow down the entire esphome core loop. That's ok when it's only executed every so often, but not if it's done every loop cycle.

got it, i will protect by update cycle

I would prefere to reuse what you did on pulse_count module with interruption, what is your advise?

OttoWinter · 2019-04-07T14:02:50Z

src/esphome/sensor/ppd42x.cpp

+  this->lowpulseoccupancy_02_5_ = this->lowpulseoccupancy_02_5_ + duration_pl_02_5;
+  this->lowpulseoccupancy_10_0_ = this->lowpulseoccupancy_10_0_ + duration_pl_10_0;
+
+  if (now - this->starttime_ > this->timeout_us_) {


You're comparing a value in ms to one in us. Please just update and publish data in update

OttoWinter · 2019-04-07T15:17:15Z

src/esphome/sensor/ppd42x.cpp

+    case PPD42X_TYPE: {
+      float pl_02_5_concentration = us_to_pl(this->lowpulseoccupancy_02_5_, this->timeout_us_);
+      float pl_10_0_concentration = us_to_pl(this->lowpulseoccupancy_10_0_, this->timeout_us_);
+      ESP_LOGD(TAG, "Got PM2.5 Concentration %f pcs/L, PM10.0 Concentration: %f pcs/L", pl_02_5_concentration,


Suggested change

ESP_LOGD(TAG, "Got PM2.5 Concentration %f pcs/L, PM10.0 Concentration: %f pcs/L", pl_02_5_concentration,

ESP_LOGD(TAG, "Got PM2.5 Concentration %.0f pcs/L, PM10.0 Concentration: %.0f pcs/L", pl_02_5_concentration,

OttoWinter · 2019-04-07T15:19:13Z

src/esphome/sensor/ppd42x.cpp

+        this->pl_02_5_sensor_->publish_state(pl_02_5_concentration);
+      if (this->pl_10_0_sensor_ != nullptr)
+        this->pl_10_0_sensor_->publish_state(pl_10_0_concentration);
+      break;


What is the difference between these switch cases? They all look the same to me.

we may have only one sensor ? PM2.5 or PM10.0 or both

No, I mean why do you differentiate between this->ctype_ ? All the switch cases look the same to me.

OttoWinter · 2019-04-07T15:19:43Z

src/esphome/sensor/ppd42x.cpp

+  }
+}
+float PPD42XComponent::us_to_pl(uint32_t sample_length, uint32_t time_pm) {
+  float ratio = time_pm / (sample_length * 10.0f);


Why does this depend on the timeout value?

this is the recommended max value to listen to !

I mean why does this calculation depend on the timeout? The sensor doesn't know which timeout we chose, so how can this calculation depend on the timeout value this->timeout_us_ we chose?

nop, the sensor send continuously data.
we cannot stay stuck too long to lisning the end of the signal, so we timeout...

OttoWinter · 2019-04-07T15:21:04Z

src/esphome/sensor/ppd42x.h

+  uint32_t lowpulseoccupancy_10_0_{0};
+
+  uint32_t last_transmission_{0};
+  uint32_t ui_{60000};


What is this value for?

ui_ is the update interval, name too short ?

pi4homez · 2019-04-08T21:01:07Z

Hi Otto, can you please help to resolve this conflict? i do not know how to do it

pi4homez

try to solve conflict :(

pi4homez

ok?

pi4homez

OK for merge?

conflict

cyberjunky · 2020-02-04T08:27:25Z

Any chance this gets merged soon?

vespadj · 2021-06-04T16:50:41Z

I'm also waiting for this merge.
As workaround I'm using ~~pulse_width~~ / duty_cycle
but the output value is in % and it's low meaningful.
PPD42 output is LPO (low pulse occupacy), so
for 0=clean and 0> pullution

pin:
      number: GPIO13 # your input
      inverted: true

pi4homez added 11 commits March 30, 2019 19:10

test

eb4ee37

tests.yaml

49ed1e3

us_to_pm fix

9b8a2da

us_to_pm fix 2

f001306

pm_02_5_pin_ fix

c5b0579

pm_02_5_pin_ fix 2

92055b2

uper case fix

da62e60

ident fix

d330b25

spaces fix

93a4742

spaces fix 2

eea52c8

spaces fix 3

ff5ccdd

OttoWinter reviewed Mar 31, 2019

View reviewed changes

pi4homez added 14 commits March 31, 2019 15:25

spaces fix 4

6c4d904

test

9d89b61

tests.yaml

a52c2a6

us_to_pm fix

96f38d5

us_to_pm fix 2

f6d1f44

pm_02_5_pin_ fix

abf3fc8

pm_02_5_pin_ fix 2

5c81c0e

uper case fix

c4de101

ident fix

f9fbfc3

spaces fix

823f72b

spaces fix 2

1cb9e49

spaces fix 3

40f1fa8

spaces fix 4

cfefff8

Merge branch 'PPD42X' of https://github.com/pi4homez/esphome-core int…

2110a3c

…o PPD42X

pi4homez added 3 commits March 31, 2019 19:04

ppd42x txt 5

09196ff

Refactore ppd42x.py

a88d08a

Refactore ppd42x.py

a35e654

pi4homez added 5 commits April 7, 2019 14:18

adapt +++++

920c14d

adapt +++++!

9796be0

adapt +++++git add .

c588de9

adapt ++++git add .git add .git add .

ea5b175

adapt ++++++

491fb94

OttoWinter reviewed Apr 7, 2019

View reviewed changes

pi4homez added 13 commits April 7, 2019 17:39

adapt +++++++

d65557c

includ otto remarks

52058f3

includ otto remarks

a7b16b1

includ otto remarks

38dff4d

includ otto remarks

6420022

includ otto remarks

5b80aa8

includ otto remarks

9aab896

includ otto remarks

b9fdb4e

includ otto remarks

c6075cd

includ otto remarks

f582d7a

includ otto remarks

5dea20f

includ otto remarks

5b92680

include otto remarks

20c8739

pi4homez and others added 2 commits April 10, 2019 20:43

include otto remarks

6eebc5b

Update defines.h

d1fdc67

pi4homez commented Apr 14, 2019

View reviewed changes

pi4homez added 2 commits April 14, 2019 14:06

res conflict

0146dd5

res conflict

3f7d1d6

pi4homez commented Apr 14, 2019

View reviewed changes

conflict

feef5e2

conflict


		namespace sensor {

		class Ppd42xSensorComponent : public PollingSensorComponent {

	ESP_LOGD(TAG, "Got PM2.5 Concentration %f pcs/L, PM10.0 Concentration: %f pcs/L", pl_02_5_concentration,
	ESP_LOGD(TAG, "Got PM2.5 Concentration %.0f pcs/L, PM10.0 Concentration: %.0f pcs/L", pl_02_5_concentration,

Uh oh!

Conversation

pi4homez commented Mar 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OttoWinter commented Mar 31, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pi4homez Apr 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pi4homez commented Apr 8, 2019

Uh oh!

pi4homez left a comment

Choose a reason for hiding this comment

Uh oh!

pi4homez left a comment

Choose a reason for hiding this comment

Uh oh!

pi4homez left a comment

Choose a reason for hiding this comment

Uh oh!

cyberjunky commented Feb 4, 2020

Uh oh!

vespadj commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pi4homez commented Mar 31, 2019 •

edited

Loading

pi4homez Apr 8, 2019 •

edited

Loading

vespadj commented Jun 4, 2021 •

edited

Loading