Add reset modes

[brianignacio5]

Fix #43
Fix #177
Fix #178

Add Before and after reset modes options

[github-actions]

Download the artifacts for this pull request:

• esptool-js-0.5.3.tgz.zip

[makermelissa]

Ok, tested and it's still resetting. I believe this is because you are now calling reset in 2 locations (probably due to the rebasing).

1. The existing function constructResetSequency() (misspelling?) is still being called which creates an array of resets. This is then called inside of _connectAttempt.
2. Your function constructResetSequence() is being called as well, but it does take mode into account.

It seems like it would be best to combine the 2 functions and return an array of reset sequences. Perhaps if mode is "no_reset", then possibly return an empty array and leave the call inside of _connectAttempt like it is now. To deal with the empty array maybe have some kind of empty reset sequence or just avoid calling the reset function altogether.

Either way, I think a combination of the 2 methods would work best. Would you like me to make a PR for this PR or you just handle it?

[brianignacio5]

Thank you for the fix @makermelissa I've pushed the changed from #181 here.

Could you test it again ?

[makermelissa]

Of course.

[makermelissa]

Tested and it is working great.

[balloob]

you already checked the variable exists, so you don't need to add ? after resetConstructors

this.resetConstructors.classicReset = options.resetConstructors.classicReset;

Also, you can just use

    this.resetConstructors = {
      classicReset: (transport, resetDelay) => new ClassicReset(transport, resetDelay),
      customReset: (transport, sequenceString) => new CustomReset(transport, sequenceString),
      hardReset: (transport, usingUsbOtg) => new HardReset(transport, usingUsbOtg),
      usbJTAGSerialReset: (transport) => new UsbJtagSerialReset(transport),
      ...(options.resetConstructors || {})
    };