Merged
Conversation
|
Download the artifacts for this pull request: |
tyeth
pushed a commit
to tyeth/read-partitions-esptool-js
that referenced
this pull request
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
ESP32C3ROMclass insrc/targets/esp32c3.tsto enhance chip versioning and description functionality. The changes include splitting the chip version retrieval into separate methods for major and minor versions and improving the chip description logic to include detailed revision information.Enhancements to chip versioning:
getMinorChipVersion(loader: ESPLoader): Promise<number>method to calculate the minor chip version by reading specific EFUSE register bits.getMajorChipVersion(loader: ESPLoader): Promise<number>method to calculate the major chip version by reading specific EFUSE register bits.Improvements to chip description:
getChipDescription(loader: ESPLoader)to include a mapping of chip package types and detailed revision information using the newly added major and minor version methods.Checklist
Before submitting a Pull Request, please ensure the following: