Skip to content

Add support for scala-native and scalajs 1.0#61

Open
marcesquerra wants to merge 1 commit intoestatico:masterfrom
marcesquerra:AddScalaNative
Open

Add support for scala-native and scalajs 1.0#61
marcesquerra wants to merge 1 commit intoestatico:masterfrom
marcesquerra:AddScalaNative

Conversation

@marcesquerra
Copy link

@marcesquerra marcesquerra commented Apr 10, 2020

In a project I'm working on, I would like to use scala-newtype from both scala-native and scalajs 1.0.

If you find it useful, I've spent a bit of time trying to upgrade scalajs and add support for scala-native into your project.

In summary, this PR does the following:

  • Upgrade the version of the related sbt plugins, plus adding the scala-native ones.
  • Add the scala-native platform to the core project (not to the cats testing one)
  • Add a small bit of configuration specific for the scala-native project
  • Upgrades the version of scala test (and adds an extra submodule that in the new version of scalatest lives outside of the main library)
  • Extract one test so that it only runs for JVM and JS (doesn't work on native: ConcurrentHashMap has not been implemented there)

@marcesquerra
Copy link
Author

I realise now there already is a PR to upgrade scalajs, if you merge that at some point, I'll fix this afterwards :)

@marcesquerra marcesquerra force-pushed the AddScalaNative branch 2 times, most recently from dc792bf to 33a3568 Compare April 17, 2020 13:49
@marcesquerra
Copy link
Author

Now this show be ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant