Skip to content

Draft implementation of testing cache in robustness tests#20354

Closed
serathius wants to merge 4 commits intoetcd-io:mainfrom
serathius:robustness-cache
Closed

Draft implementation of testing cache in robustness tests#20354
serathius wants to merge 4 commits intoetcd-io:mainfrom
serathius:robustness-cache

Conversation

@serathius
Copy link
Copy Markdown
Member

For now just to show how the integration could look like, a more permanent solution would have a separate test scenario.

I think the tests deadlocks because cache doesn't support progress notifications.

/cc @apullo777 @MadhavJivrajani

@k8s-ci-robot
Copy link
Copy Markdown

@serathius: GitHub didn't allow me to request PR reviews from the following users: apullo777.

Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

For now just to show how the integration could look like, a more permanent solution would have a separate test scenario.

I think the tests deadlocks because cache doesn't support progress notifications.

/cc @apullo777 @MadhavJivrajani

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.25%. Comparing base (3531079) to head (3688609).
⚠️ Report is 268 commits behind head on main.

Additional details and impacted files

see 32 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20354      +/-   ##
==========================================
+ Coverage   69.21%   69.25%   +0.04%     
==========================================
  Files         422      422              
  Lines       34817    34819       +2     
==========================================
+ Hits        24097    24113      +16     
+ Misses       9327     9315      -12     
+ Partials     1393     1391       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3531079...3688609. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius
Copy link
Copy Markdown
Member Author

Extracted #20355

@serathius serathius force-pushed the robustness-cache branch 4 times, most recently from 654c831 to 6488548 Compare August 14, 2025 09:27
@serathius
Copy link
Copy Markdown
Member Author

/retest

@serathius serathius force-pushed the robustness-cache branch 2 times, most recently from 157d75c to 7992960 Compare August 22, 2025 07:44
@serathius serathius force-pushed the robustness-cache branch 2 times, most recently from a500ce2 to 349587e Compare August 29, 2025 14:09
@serathius serathius force-pushed the robustness-cache branch 2 times, most recently from 7771d23 to dec6d09 Compare August 29, 2025 15:06
…tes finish and max revision is provided

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
apullo777 and others added 2 commits October 2, 2025 11:38
Signed-off-by: Peter Chang <peter.yaochen.chang@gmail.com>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Oct 2, 2025

@serathius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify 3688609 link true /test pull-etcd-verify
pull-etcd-grpcproxy-integration-arm64 3688609 link true /test pull-etcd-grpcproxy-integration-arm64
pull-etcd-grpcproxy-integration-amd64 3688609 link true /test pull-etcd-grpcproxy-integration-amd64
pull-etcd-unit-test-386 3688609 link true /test pull-etcd-unit-test-386
pull-etcd-unit-test-arm64 3688609 link true /test pull-etcd-unit-test-arm64
pull-etcd-unit-test-amd64 3688609 link true /test pull-etcd-unit-test-amd64
pull-etcd-integration-2-cpu-arm64 3688609 link true /test pull-etcd-integration-2-cpu-arm64
pull-etcd-integration-1-cpu-arm64 3688609 link true /test pull-etcd-integration-1-cpu-arm64
pull-etcd-integration-4-cpu-arm64 3688609 link true /test pull-etcd-integration-4-cpu-arm64
pull-etcd-integration-2-cpu-amd64 3688609 link true /test pull-etcd-integration-2-cpu-amd64
pull-etcd-integration-4-cpu-amd64 3688609 link true /test pull-etcd-integration-4-cpu-amd64
pull-etcd-integration-1-cpu-amd64 3688609 link true /test pull-etcd-integration-1-cpu-amd64
pull-etcd-coverage-report 3688609 link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 4, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 4, 2025
@github-actions github-actions bot closed this Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants