Draft implementation of testing cache in robustness tests#20354
Draft implementation of testing cache in robustness tests#20354serathius wants to merge 4 commits intoetcd-io:mainfrom
Conversation
|
@serathius: GitHub didn't allow me to request PR reviews from the following users: apullo777. Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 32 files with indirect coverage changes @@ Coverage Diff @@
## main #20354 +/- ##
==========================================
+ Coverage 69.21% 69.25% +0.04%
==========================================
Files 422 422
Lines 34817 34819 +2
==========================================
+ Hits 24097 24113 +16
+ Misses 9327 9315 -12
+ Partials 1393 1391 -2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
24d5202 to
684557d
Compare
|
Extracted #20355 |
684557d to
ba2e0d8
Compare
654c831 to
6488548
Compare
6488548 to
117e71d
Compare
|
/retest |
edc9ecf to
ad5c5d5
Compare
ad5c5d5 to
a22251d
Compare
157d75c to
7992960
Compare
a500ce2 to
349587e
Compare
7771d23 to
dec6d09
Compare
…tes finish and max revision is provided Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
dec6d09 to
ac099c9
Compare
Signed-off-by: Peter Chang <peter.yaochen.chang@gmail.com>
|
@serathius: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
For now just to show how the integration could look like, a more permanent solution would have a separate test scenario.
I think the tests deadlocks because cache doesn't support progress notifications.
/cc @apullo777 @MadhavJivrajani