Skip to content

cache: handle unsupported watch opts#20363

Merged
MadhavJivrajani merged 1 commit intoetcd-io:mainfrom
apullo777:validate-watch-opts
Jul 23, 2025
Merged

cache: handle unsupported watch opts#20363
MadhavJivrajani merged 1 commit intoetcd-io:mainfrom
apullo777:validate-watch-opts

Conversation

@apullo777
Copy link
Copy Markdown
Contributor

@k8s-ci-robot
Copy link
Copy Markdown

Hi @apullo777. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius
Copy link
Copy Markdown
Member

Please rebase

Comment thread cache/cache.go Outdated
@MadhavJivrajani
Copy link
Copy Markdown
Contributor

Not sure if the rebase was successful, I still see changes from #20362 in here

Also feel free to remove from draft state now

@apullo777 apullo777 force-pushed the validate-watch-opts branch 2 times, most recently from fe374b0 to d8a7874 Compare July 22, 2025 02:44
@apullo777 apullo777 marked this pull request as ready for review July 22, 2025 02:44
@apullo777 apullo777 force-pushed the validate-watch-opts branch from d8a7874 to f595018 Compare July 22, 2025 02:49
@apullo777
Copy link
Copy Markdown
Contributor Author

apullo777 commented Jul 22, 2025

Not sure if the rebase was successful, I still see changes from #20362 in here

Also feel free to remove from draft state now

Sorry. Just rebased. I will also open a separate PR to make cancelReason public.

@apullo777 apullo777 force-pushed the validate-watch-opts branch from f595018 to eca1509 Compare July 22, 2025 12:55
@serathius
Copy link
Copy Markdown
Member

It might take some time to get the cancel Reason PR merged. Maybe we could just remove dependence on that and merge the changes to cache?

@apullo777
Copy link
Copy Markdown
Contributor Author

apullo777 commented Jul 22, 2025

Ok. Maybe to temporarily remove the test for WithPreKV so that integration can pass without exposing cancelReason?

@apullo777 apullo777 force-pushed the validate-watch-opts branch from eca1509 to 0788f28 Compare July 22, 2025 20:08
@serathius
Copy link
Copy Markdown
Member

CancelReason change was merged. We can move forward. Please rebase.

@serathius
Copy link
Copy Markdown
Member

/ok-to-test

@MadhavJivrajani
Copy link
Copy Markdown
Contributor

/test pull-etcd-integration-4-cpu-arm64

Looks like #20378 (comment) is breaking the verify test

@fuweid fyi ^

@apullo777 let's add in a separate commit to this PR to fix that doc comment.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Jul 23, 2025

@apullo777 please rebase it when you have time. thanks!

Signed-off-by: Peter Chang <peter.yaochen.chang@gmail.com>
@apullo777 apullo777 force-pushed the validate-watch-opts branch from 0788f28 to 59f2617 Compare July 23, 2025 11:54
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.15%. Comparing base (df6b790) to head (59f2617).
Report is 1 commits behind head on main.

Additional details and impacted files

see 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20363      +/-   ##
==========================================
+ Coverage   69.05%   69.15%   +0.09%     
==========================================
  Files         415      415              
  Lines       34630    34630              
==========================================
+ Hits        23915    23947      +32     
+ Misses       9317     9289      -28     
+ Partials     1398     1394       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6b790...59f2617. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apullo777, MadhavJivrajani, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MadhavJivrajani MadhavJivrajani merged commit 7137745 into etcd-io:main Jul 23, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants