cache: handle unsupported watch opts#20363
Conversation
|
Hi @apullo777. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
66b045c to
5c16198
Compare
|
Please rebase |
|
Not sure if the rebase was successful, I still see changes from #20362 in here Also feel free to remove from draft state now |
fe374b0 to
d8a7874
Compare
d8a7874 to
f595018
Compare
Sorry. Just rebased. I will also open a separate PR to make cancelReason public. |
f595018 to
eca1509
Compare
|
It might take some time to get the cancel Reason PR merged. Maybe we could just remove dependence on that and merge the changes to cache? |
|
Ok. Maybe to temporarily remove the test for WithPreKV so that integration can pass without exposing cancelReason? |
eca1509 to
0788f28
Compare
|
CancelReason change was merged. We can move forward. Please rebase. |
|
/ok-to-test |
|
/test pull-etcd-integration-4-cpu-arm64 Looks like #20378 (comment) is breaking the verify test @fuweid fyi ^ @apullo777 let's add in a separate commit to this PR to fix that doc comment. |
|
@apullo777 please rebase it when you have time. thanks! |
Signed-off-by: Peter Chang <peter.yaochen.chang@gmail.com>
0788f28 to
59f2617
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 18 files with indirect coverage changes @@ Coverage Diff @@
## main #20363 +/- ##
==========================================
+ Coverage 69.05% 69.15% +0.09%
==========================================
Files 415 415
Lines 34630 34630
==========================================
+ Hits 23915 23947 +32
+ Misses 9317 9289 -28
+ Partials 1398 1394 -4 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apullo777, MadhavJivrajani, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
@serathius @MadhavJivrajani