Skip to content

cache: refactor validateWatch to use a switch for unsupported watch ops#20419

Merged
serathius merged 1 commit intoetcd-io:mainfrom
apullo777:refactor-validateWatch
Jul 29, 2025
Merged

cache: refactor validateWatch to use a switch for unsupported watch ops#20419
serathius merged 1 commit intoetcd-io:mainfrom
apullo777:refactor-validateWatch

Conversation

@apullo777
Copy link
Copy Markdown
Contributor

Signed-off-by: Peter Chang <peter.yaochen.chang@gmail.com>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @apullo777. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not spend a lot of time on this code as we will just implement the methods in the future.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apullo777, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Copy Markdown
Member

/ok-to-test

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.23%. Comparing base (030ecec) to head (12457c0).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

see 153 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20419      +/-   ##
==========================================
+ Coverage   62.11%   69.23%   +7.12%     
==========================================
  Files         402      416      +14     
  Lines       33559    34696    +1137     
==========================================
+ Hits        20845    24023    +3178     
+ Misses      11155     9285    -1870     
+ Partials     1559     1388     -171     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030ecec...12457c0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius serathius merged commit 1eb4d3c into etcd-io:main Jul 29, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants