cache: refactor validateWatch to use a switch for unsupported watch ops#20419
cache: refactor validateWatch to use a switch for unsupported watch ops#20419serathius merged 1 commit intoetcd-io:mainfrom
Conversation
Signed-off-by: Peter Chang <peter.yaochen.chang@gmail.com>
|
Hi @apullo777. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
serathius
left a comment
There was a problem hiding this comment.
We should not spend a lot of time on this code as we will just implement the methods in the future.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apullo777, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 153 files with indirect coverage changes @@ Coverage Diff @@
## main #20419 +/- ##
==========================================
+ Coverage 62.11% 69.23% +7.12%
==========================================
Files 402 416 +14
Lines 33559 34696 +1137
==========================================
+ Hits 20845 24023 +3178
+ Misses 11155 9285 -1870
+ Partials 1559 1388 -171 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
@serathius @MadhavJivrajani