Skip to content

cache: move batching to demux so that ringBuffer stores single item#20502

Merged
serathius merged 1 commit intoetcd-io:mainfrom
apullo777:ringbuffer-demux-batching
Aug 19, 2025
Merged

cache: move batching to demux so that ringBuffer stores single item#20502
serathius merged 1 commit intoetcd-io:mainfrom
apullo777:ringbuffer-demux-batching

Conversation

@apullo777
Copy link
Copy Markdown
Contributor

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
#20477 follow-up to move batching into demux to further simplify ringbuffer interface
@serathius @MadhavJivrajani

Signed-off-by: Peter Chang <peter.yaochen.chang@gmail.com>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @apullo777. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius
Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apullo777, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.49%. Comparing base (c218423) to head (09a384a).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

see 147 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20502      +/-   ##
==========================================
- Coverage   69.15%   62.49%   -6.67%     
==========================================
  Files         418      405      -13     
  Lines       34696    33590    -1106     
==========================================
- Hits        23995    20991    -3004     
- Misses       9300    11025    +1725     
- Partials     1401     1574     +173     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c218423...09a384a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius serathius merged commit d8493c1 into etcd-io:main Aug 19, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants