cache: change demux.Broadcast to accept clientv3.WatchResponse#20639
cache: change demux.Broadcast to accept clientv3.WatchResponse#20639serathius merged 1 commit intoetcd-io:mainfrom
Conversation
Signed-off-by: Peter Chang <peter.yaochen.chang@gmail.com>
|
Hi @apullo777. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apullo777, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 39 files with indirect coverage changes @@ Coverage Diff @@
## main #20639 +/- ##
==========================================
- Coverage 68.92% 68.57% -0.36%
==========================================
Files 417 420 +3
Lines 34648 34783 +135
==========================================
- Hits 23882 23852 -30
- Misses 9350 9534 +184
+ Partials 1416 1397 -19 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@apullo777: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
@serathius @MadhavJivrajani