Skip to content

cache: change demux.Broadcast to accept clientv3.WatchResponse#20639

Merged
serathius merged 1 commit intoetcd-io:mainfrom
apullo777:broadcast-watchresp
Sep 9, 2025
Merged

cache: change demux.Broadcast to accept clientv3.WatchResponse#20639
serathius merged 1 commit intoetcd-io:mainfrom
apullo777:broadcast-watchresp

Conversation

@apullo777
Copy link
Copy Markdown
Contributor

Signed-off-by: Peter Chang <peter.yaochen.chang@gmail.com>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @apullo777. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apullo777, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Copy Markdown
Member

/ok-to-test

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.57%. Comparing base (aeb47ee) to head (ce4b451).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 39 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20639      +/-   ##
==========================================
- Coverage   68.92%   68.57%   -0.36%     
==========================================
  Files         417      420       +3     
  Lines       34648    34783     +135     
==========================================
- Hits        23882    23852      -30     
- Misses       9350     9534     +184     
+ Partials     1416     1397      -19     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb47ee...ce4b451. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link
Copy Markdown

@apullo777: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-integration-2-cpu-amd64 ce4b451 link true /test pull-etcd-integration-2-cpu-amd64
pull-etcd-coverage-report ce4b451 link true /test pull-etcd-coverage-report
pull-etcd-robustness-amd64 ce4b451 link true /test pull-etcd-robustness-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius
Copy link
Copy Markdown
Member

/retest

@serathius serathius merged commit 5fec99c into etcd-io:main Sep 9, 2025
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants