Gopkg.toml: remove unnecessary constraints and add pruning#9258
Merged
gyuho merged 1 commit intoetcd-io:masterfrom Jan 31, 2018
tamird:dep-cleanup
Merged
Gopkg.toml: remove unnecessary constraints and add pruning#9258gyuho merged 1 commit intoetcd-io:masterfrom tamird:dep-cleanup
gyuho merged 1 commit intoetcd-io:masterfrom
tamird:dep-cleanup
Conversation
Confirmed that `dep ensure` results in no version changes in Gopkg.lock.
Codecov Report
@@ Coverage Diff @@
## master #9258 +/- ##
==========================================
+ Coverage 75.74% 75.87% +0.12%
==========================================
Files 363 363
Lines 30200 30200
==========================================
+ Hits 22876 22914 +38
+ Misses 5718 5683 -35
+ Partials 1606 1603 -3
Continue to review full report at Codecov.
|
gyuho
approved these changes
Jan 31, 2018
Contributor
gyuho
left a comment
There was a problem hiding this comment.
lgtm. Thanks!
/cc @fanminshi and #9224
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed that
dep ensureresults in no version changes in Gopkg.lock.@gyuho