Skip to content

chore: Rewards apis no longer experimental #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfyone merged 5 commits into from
Feb 18, 2024
Merged

chore: Rewards apis no longer experimental #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
496519a
Revert "Move state endpoint to `beacon` namespace (#353)"
rolfyone Sep 19, 2023
9118abb
Merge remote-tracking branch 'upstream/master'
rolfyone Sep 19, 2023
0cfeefd
Merge remote-tracking branch 'upstream/master'
rolfyone Jan 31, 2024
fefece6
Merge remote-tracking branch 'upstream/master'
rolfyone Feb 18, 2024
809f1fd
Removed Experimental tag from rewards endpoints
rolfyone Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apis/beacon/rewards/attestations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ post:
tags:
- Beacon
- Rewards
- Experimental
parameters:
- name: epoch
in: path
Expand Down
1 change: 0 additions & 1 deletion apis/beacon/rewards/blocks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ get:
tags:
- Beacon
- Rewards
- Experimental
parameters:
- name: block_id
in: path
Expand Down
1 change: 0 additions & 1 deletion apis/beacon/rewards/sync_committee.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ post:
tags:
- Beacon
- Rewards
- Experimental
parameters:
- name: block_id
in: path
Expand Down
2 changes: 0 additions & 2 deletions beacon-node-oapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ tags:
[Checkout validator flow](./validator-flow.md) to learn how to use this api.
- name: Rewards
description: Endpoints to query rewards and penalties for validators.
- name: Experimental
Copy link
Copy Markdown
Contributor

@ensi321 ensi321 Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfyone I know this has been merged but imo we should keep the Experimental tag and its description just in case any future endpoints require it

Copy link
Copy Markdown
Contributor Author

@rolfyone rolfyone Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll definitely re-use it, trivial to re-add. no point keeping a mess around imo...

Copy link
Copy Markdown
Member

@nflaig nflaig Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also keeps an empty section around in the api explorer (at the bottom)

description: Endpoints that are not stable or fully implemented by each client.

paths:

Expand Down