-
Notifications
You must be signed in to change notification settings - Fork 212
Add head_v2 event and deprecate head event
#590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chong-he
wants to merge
17
commits into
ethereum:master
Choose a base branch
from
chong-he:event-head
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a4f263b
new_head event
chong-he 8b3a640
update pr number
chong-he fde1cb3
update to head_v2
chong-he cddd3fa
update attester.yaml
chong-he 0c484bd
change duty to epoch
chong-he cbdbe5f
update changes.md
chong-he 55a073f
Update apis/eventstream/index.yaml
chong-he 61ffaec
move up
chong-he 81bb82d
revise attester and proposer.v2
chong-he c776a6c
revise ptc dependent root
chong-he 1879edd
Merge branch 'master' into event-head
chong-he cdebb44
Add slot definition
chong-he 4048c90
update head event
chong-he 0268d02
revise
chong-he d81c30a
typo
chong-he cfd78f9
delete release file
chong-he 5c3241e
Merge remote-tracking branch 'upstream/master' into event-head
chong-he File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the purpose of having the
previous_epoch_dependent_rootin the head event?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the equivalent field to the current head event field
previous_duty_dependent_root, so I keep it in the response. Is it not required now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I think I got what you mean. The
previous_duty_dependent_rootin head is equivalent to the nowcurrent_epoch_dependent_rootinhead_v2, so we don't need to haveprevious_epoch_dependent_rootin the event. Is that what you mean?