Pass aggregate.committee_bits to get_committee_indices#4742
Merged
jtraglia merged 3 commits intoethereum:masterfrom Nov 14, 2025
Merged
Pass aggregate.committee_bits to get_committee_indices#4742jtraglia merged 3 commits intoethereum:masterfrom
aggregate.committee_bits to get_committee_indices#4742jtraglia merged 3 commits intoethereum:masterfrom
Conversation
jtraglia
reviewed
Nov 13, 2025
| - [REJECT] `len(committee_indices) == 1`, where | ||
| `committee_indices = get_committee_indices(aggregate)`. | ||
| `committee_indices = get_committee_indices(aggregate.committee_bits)`. | ||
| - [REJECT] `aggregate.data.index == 0` |
Member
There was a problem hiding this comment.
Good catch. I find this section to be a little confusing. It's missing the aggregate = signed_aggregrate_and_proof.message.aggregate alias. In this PR, could you also add a paragraph near the beginning similar to the following:
consensus-specs/specs/gloas/p2p-interface.md
Lines 250 to 252 in 11e1509
jtraglia
changed the title
aggregate.committee_bits to get_committee_indices
jtraglia
approved these changes
Nov 14, 2025
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Good changes. Thanks for the PR 🙂
wyeditthea
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the beacon_aggregate_and_proof validation to call get_committee_indices(aggregate.committee_bits) instead of get_committee_indices(aggregate). Electra defines get_committee_indices to accept a committee bitvector and all related code paths and tests use .committee_bits. This change aligns the networking spec with the Electra attestation format introduced by EIP-7549 and avoids implementer confusion.