Add note for is_builder_payment_withdrawable#4770
Merged
jtraglia merged 1 commit intoethereum:masterfrom Dec 4, 2025
Merged
Conversation
leolara
approved these changes
Dec 2, 2025
Member
Author
|
Also, this is what @potuz said about it: 
|
21 tasks
jihoonsong
reviewed
Dec 19, 2025
| ##### New `is_builder_payment_withdrawable` | ||
|
|
||
| *Note*: Builder payments are immediately withdrawable if the builder is not | ||
| slashed; this allows the builder to submit bids as soon as it becomes active. On |
Member
There was a problem hiding this comment.
this allows the builder to submit bids as soon as it becomes active.
How this function allows builders to submit bids as soon as it becomes active? This function is called during withdrawal processing, not upon bid submission.
Contributor
There was a problem hiding this comment.
@jihoonsong I think this function is getting removed in #4788
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
is_builder_payment_withdrawablefunction is a bit unintuitive. This PR adds a note to explain things.This PR also reverses the condition to match the new note.
PS: We're annotating this function because it has confused multiple devs, including myself.