Fix is_builder_payment_withdrawable function#4774
Merged
jtraglia merged 1 commit intoethereum:masterfrom Dec 5, 2025
Merged
Conversation
gitToki
changed the title
is_builder_payment_withdrawable function
jtraglia
approved these changes
Dec 4, 2025
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
Yup, good catch. Not sure how I missed that. Thank you!
PS: @ensi321 tried to point this out too but there was a misunderstanding.
potuz
suggested changes
Dec 5, 2025
potuz
approved these changes
Dec 5, 2025
Contributor
potuz
left a comment
potuz
left a comment
There was a problem hiding this comment.
No, my bad this is actually correct, there must be no test for this then.
21 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were checking if the builder had not been slashed or if the withdrawable epoch was in the future compared to the current epoch.
We should check if the builder has not been slashed or if the current epoch is equal to or has passed the withdrawable epoch.