Move with_custom_context to tests/infra/context and add tests for it#4776
Open
kysre wants to merge 3 commits intoethereum:masterfrom
Open
Move with_custom_context to tests/infra/context and add tests for it#4776kysre wants to merge 3 commits intoethereum:masterfrom
kysre wants to merge 3 commits intoethereum:masterfrom
Conversation
kysre
changed the title
Member
|
It doesn't pass all the checks |
leolara
reviewed
Jan 7, 2026
| state = _prepare_state(balances_fn, threshold_fn, spec, phases) | ||
| _custom_state_cache_dict[key] = state.get_backing() | ||
|
|
||
| # Wrap cached immutable backing with a fresh view |
Member
There was a problem hiding this comment.
I think it was important in this comment, that it is reason we don't need to copy
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR with_custom_context decorator in
tests/core/pyspec/eth2spec/test/context.pyis moved totests/infra/context.py. Also some tests for this decorator is added intests/infra/test_with_custom_context.pyFixes #4669