Add Gloas fork choice test for new validator deposit#4960
Open
unnawut wants to merge 16 commits intoethereum:masterfrom
Open
Add Gloas fork choice test for new validator deposit#4960unnawut wants to merge 16 commits intoethereum:masterfrom
unnawut wants to merge 16 commits intoethereum:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempting to resolve the TODO in electra's test_new_validator_deposit_with_multiple_epoch_transitions
test_new_validator_deposit_with_multiple_epoch_transitions()for Gloas, covering deposit processing through fork choice with reorgs, basically the same goal as Electra's test case but with support for execution payload commit & revealprepare_execution_payload_envelope()from the test case file to the helper file because it's now being used by both test_process_execution_payload.py and test_deposit_with_reorg.pytest/helpers/execution_payload.py:reveal_payload_to_state()that prepares and processes the execution payload envelopetest/helpers/attestations.py:state_transition_with_full_block()acceptsenvelopeswhere if provided, it'll performreveal_payload_to_state()after state transitiontest/helpers/fork_choice.py:tick_and_add_block()accepts optionalenvelopeand triggerson_execution_payload()if envelope providedapply_next_slots_with_attestations()acceptswith_payload_revealso it knows to checkstore.payload_statesif the flag is presentChecklist
make lintmake test fork=gloas k=test_new_validator_deposit_with_multiple_epoch_transitionsmake reftests fork=gloas runner=fork_choice