Fix: remove phase0 redundant check#5016
Closed
Alleysira wants to merge 1 commit intoethereum:masterfrom
Closed
Conversation
Member
|
Hi @Alleysira, thanks for your contribution. I just wanted to let you know that this will be removed and replaced with code in #4902. Please understand that I'm closing this PR in lieu of #4902. Feel free to continue your study and further contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi there,
I'm studying consensus-spec recently and found that the
beacon_aggregate_and_proofgossip validation inspecs/phase0/p2p-interface.mdcontains two identical[REJECT]checks that test the exact same condition with the same inputs.consensus-specs/specs/phase0/p2p-interface.md
Lines 513 to 514 in 1baa05e
and
consensus-specs/specs/phase0/p2p-interface.md
Lines 522 to 523 in 1baa05e
This PR removes the second check and keep the first which uses the more specific
aggregate attestationwording consistent with the surrounding context.