Skip to content

Fix: remove phase0 redundant check#5016

Closed
Alleysira wants to merge 1 commit intoethereum:masterfrom
Alleysira:fix-phase0-redundant-checks
Closed

Fix: remove phase0 redundant check#5016
Alleysira wants to merge 1 commit intoethereum:masterfrom
Alleysira:fix-phase0-redundant-checks

Conversation

@Alleysira
Copy link
Copy Markdown
Contributor

Description

Hi there,

I'm studying consensus-spec recently and found that the beacon_aggregate_and_proof gossip validation in specs/phase0/p2p-interface.md contains two identical [REJECT] checks that test the exact same condition with the same inputs.

- _[REJECT]_ The aggregate attestation has participants -- that is,
`len(get_attesting_indices(state, aggregate)) >= 1`.

and

- _[REJECT]_ The attestation has participants -- that is,
`len(get_attesting_indices(state, aggregate)) >= 1`.

This PR removes the second check and keep the first which uses the more specific aggregate attestation wording consistent with the surrounding context.

@jihoonsong
Copy link
Copy Markdown
Member

jihoonsong commented Mar 19, 2026

Hi @Alleysira, thanks for your contribution. I just wanted to let you know that this will be removed and replaced with code in #4902. Please understand that I'm closing this PR in lieu of #4902. Feel free to continue your study and further contribution :)

@jihoonsong jihoonsong closed this Mar 19, 2026
@Alleysira Alleysira deleted the fix-phase0-redundant-checks branch March 19, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants