Relax bid gossip dependency on proposer preferences#5036
Open
nflaig wants to merge 2 commits intoethereum:masterfrom
Open
Relax bid gossip dependency on proposer preferences#5036nflaig wants to merge 2 commits intoethereum:masterfrom
nflaig wants to merge 2 commits intoethereum:masterfrom
Conversation
Member
|
I disagree with this PR but let's leave it open until client devs have a chance to weigh in. In my opinion, this change would make the bid forwarding more complex for no real benefits.
|
Member
Author
|
while I opened the PR I am also not in favor of it and agree with your points |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the hard requirement for
SignedProposerPreferencesto have been seen before forwardingexecution_payload_bidmessages. Thefee_recipientandgas_limitchecks are now only applied if preferences have been seen, otherwise bids are forwarded without preference validation.This decouples the two gossip topics so that bids can flow even if preferences were delayed or missed due to network partition.
The proposer still validates bids against their own preferences locally.