Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Dec 8, 2025

πŸ—’οΈ Description

Add valid ecrecover test inputs which invoke point doubling in the multi-scalar multiplication based on the Shamir trick.

Ported from evmone unit tests:
ipsilon/evmone#1391.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Add valid ecrecover test inputs which invoke point doubling in the
multi-scalar multiplication based on the Shamir trick.

Ported from evmone unit tests:
ipsilon/evmone#1391.
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 87.31%. Comparing base (9523e75) to head (dcf19b7).
⚠️ Report is 12 commits behind head on forks/osaka.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1857   +/-   ##
============================================
  Coverage        87.31%   87.31%           
============================================
  Files              541      541           
  Lines            32832    32832           
  Branches          3015     3015           
============================================
  Hits             28668    28668           
  Misses            3557     3557           
  Partials           607      607           
Flag Coverage Ξ”
unittests 87.31% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spencer-tb spencer-tb added C-feat Category: an improvement or new feature A-test-tests Area: tests for packages/testing labels Dec 8, 2025
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. All EL clients passing this from my side!

@marioevz marioevz merged commit 180e610 into ethereum:forks/osaka Dec 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-tests Area: tests for packages/testing C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants