eth/catalyst: add SSZ-encoded engine API#33926
Draft
Giulio2002 wants to merge 7 commits intoethereum:masterfrom
Draft
eth/catalyst: add SSZ-encoded engine API#33926Giulio2002 wants to merge 7 commits intoethereum:masterfrom
Giulio2002 wants to merge 7 commits intoethereum:masterfrom
Conversation
Add SSZ-REST as an alternative Engine API transport alongside JSON-RPC. When enabled via --authrpc.ssz-rest (alias: --rest), Geth starts an additional HTTP server that accepts SSZ-encoded payloads over REST, cutting wire size ~50% and eliminating JSON encode/decode overhead. New files: - beacon/engine/ssz.go: SSZ encoding/decoding for all Engine API types - beacon/engine/ssz_test.go: round-trip tests for SSZ codecs - eth/catalyst/ssz_rest.go: SSZ-REST HTTP server with JWT auth - eth/catalyst/ssz_rest_test.go: server unit tests Modified files: - beacon/engine/types.go: CommunicationChannel, ExchangeCapabilitiesV2Response - eth/catalyst/api.go: ExchangeCapabilitiesV2, getSupportedProtocols, server wiring - node/config.go, defaults.go: SszRestEnabled, SszRestPort config - node/jwt_handler.go: exported NewJWTHandler for reuse - cmd/utils/flags.go, cmd/geth/main.go: CLI flags Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Giulio2002
requested review from
MariusVanDerWijden,
fjl,
jwasinger and
lightclient
as code owners
Giulio2002
changed the title
Member
lol the code doesn't even pass the lint |
Contributor
Author
Claude indeed made a mistake ;) |
Contributor
Author
|
also code is pretty bad because I did not even review it yet. It uses its own encoding copied from Prysm (generated). need to change that too (note that this is a big WIP, dont waste your time here yet). the moment it worked in Kurtosis, I just stopped it and decided maybe to work on it later if this goes anywhere |
…ation Remove getClientCommunicationChannels, exchangeCapabilitiesV2, and getSupportedProtocols. The SSZ-REST endpoint is now enabled solely via the --authrpc.ssz-rest flag. CLs discover it via their own --ssz-rest-url flag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Implements the SSZ-REST Engine API transport spec: ethereum/execution-apis#764 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude never makes mistakes
Test plan
go test ./beacon/engine/...— 13 SSZ round-trip tests passgo test ./eth/catalyst/...— 6 SSZ-REST server tests passgo build ./cmd/geth— compiles with--restflag🤖 Generated with Claude Code