This repository was archived by the owner on Aug 2, 2021. It is now read-only.
Open
Conversation
tzdybal
force-pushed
the
gc-quantiles-continuation
branch
from
4c2c460 to
72f23b8
Compare
tzdybal
force-pushed
the
gc-quantiles-continuation
branch
from
72f23b8 to
3355287
Compare
tzdybal
force-pushed
the
gc-quantiles-continuation
branch
from
9635f35 to
4fe64b9
Compare
tzdybal
force-pushed
the
gc-quantiles-continuation
branch
from
4fe64b9 to
365ffb7
Compare
tzdybal
force-pushed
the
gc-quantiles-continuation
branch
from
9b954e5 to
946c411
Compare
Reference to local variable was returned instead of reference to element in underlying slice.
Even more complicated test - assumes that there are multiple indexes in database (there are many index prefixes), including empty index. There are test cases that checks both positive and erroneous scenarios. Tests are failing, as implementation is incorrect (in many ways).
+ more test cases
Most important issue: quantiles.Set was not altering the original object. This is because, reference to the receiver is passed as a value, so the substitution of `q` with `append` function has only local scope. Second of all, fraction fields needs public visibility, in order to be properly JSON encoded/decoded.
tzdybal
force-pushed
the
gc-quantiles-continuation
branch
from
946c411 to
5169578
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in Progress PR for work related to garbage collection with quantiles, for better visibility.