Skip to content

Conversation

@ZePedroResende
Copy link
Contributor

@ZePedroResende ZePedroResende commented Jan 20, 2026

Why

Phoenix by default uses a *_json.ex file per view for serialising json and a fallback controller for standardise error handling and responses on controller .
We were doing this on a case by case way which is error prone and makes you repeat the same pattern .

How

  • Add a *_json.ex per controller
  • Add a fallback_controller.ex
  • Correct tests that had incorrect response for the http error
  • Cleanup miscellaneous warning

@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
stacks Ready Ready Preview, Comment Jan 21, 2026 2:28pm

Request Review

Copy link
Member

@naps62 naps62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it :shipit:

@ZePedroResende ZePedroResende added the enhancement New feature or request label Jan 21, 2026
@ZePedroResende ZePedroResende marked this pull request as ready for review January 21, 2026 14:42
@ZePedroResende ZePedroResende merged commit 0b4d51b into main Jan 21, 2026
3 checks passed
@ZePedroResende ZePedroResende deleted the zpr/cleanup branch January 21, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants