Fix link to main.js in webapp example for nested routes#246
Open
axeltlarsson wants to merge 1 commit intoevancz:masterfrom
Open
Fix link to main.js in webapp example for nested routes#246axeltlarsson wants to merge 1 commit intoevancz:masterfrom
axeltlarsson wants to merge 1 commit intoevancz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across an issue when using elm-live to serve my Elm app. If I refresh while visiting a nested route such as
localhost:8000/elm_rocks/new, the relative uri to includemain.jsis incorrect as it becomeslocalhost:8000/elm_rocks/main.jswhich fails asmain.jsis served from the root path.The error I got specifically complains about "X-Content-Type-Options: nosniff".
I'm hoping this small fix can help other Elm beginners use this wonderful language ❤️!