Planner: drop deprecated publishing keys #2 (BC)

[iseeberg79]

Follow-up to #24423, depends on #26291
based on #26293

TODO:

• UI

[iseeberg79]

@naltatis had no write access

[iseeberg79]

@naltatis looks consistent to me and is working properly for soc-based and energy-based plans,
found and solved a bug on not having published the data on close of energy-based modal resulting in persisted (database) but not updated (ui) strategy

[sourcery-ai]

Hey - I've left some high level feedback:

• In Site.publishVehicles you changed lp.PublishEffectiveValues() from asynchronous to synchronous; please double-check that this cannot block the polling loop or introduce lock contention in cases where PublishEffectiveValues does more work in the future, and consider keeping it async while explicitly publishing only the strategy synchronously if immediate strategy availability is the main concern.
• The PlanStrategy custom MarshalJSON/UnmarshalJSON convert Precondition to seconds and back; it might be worth clarifying in the struct comment that the internal time.Duration is expected to be in whole seconds and guarding against sub-second values being silently truncated.
• In core/vehicle/adapter.go the log line in SetPlanStrategy was removed; if this was useful for diagnosing planning issues, consider keeping a concise debug log (perhaps only when values actually change) instead of dropping it entirely.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `Site.publishVehicles` you changed `lp.PublishEffectiveValues()` from asynchronous to synchronous; please double-check that this cannot block the polling loop or introduce lock contention in cases where `PublishEffectiveValues` does more work in the future, and consider keeping it async while explicitly publishing only the strategy synchronously if immediate strategy availability is the main concern.
- The `PlanStrategy` custom `MarshalJSON`/`UnmarshalJSON` convert `Precondition` to seconds and back; it might be worth clarifying in the struct comment that the internal `time.Duration` is expected to be in whole seconds and guarding against sub-second values being silently truncated.
- In `core/vehicle/adapter.go` the log line in `SetPlanStrategy` was removed; if this was useful for diagnosing planning issues, consider keeping a concise debug log (perhaps only when values actually change) instead of dropping it entirely.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}